veyra/friends-of-behat-mink-extension
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Remove inline @var annotations; fix spec session name; fix @var placement

Browse Source 
- Replace all local-variable @var annotations with proper type guards:
  - MinkExtension configure closure: build inner array directly
    ($sessions[$driverType] = [$driverType => ...]) to avoid mixed offset access
  - MinkExtension loadSessions: add is_array($session) guard inside foreach
    so PHPStan narrows $session from mixed to array before key() call
  - DriverFactory::buildDriver @param broadened from array<string, mixed>
    to array<mixed> — is_array() only narrows to array<mixed> (key type
    unknown), so array<string, mixed> was unreachable at the call site
  - MinkAwareInitializer: move @var from inside constructor parameter list
    to a proper @param on the method docblock
- SessionsListenerSpec: replace 'goutte' (deleted driver) with
  'browserkit_http' as the example default session name

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Kamil Kokot
2026-06-12 18:04:18 +02:00
parent 2947994733
commit 41bac3c5b7
14 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/Behat/MinkExtension/Listener/SessionsListenerSpec.php
View File

@@ -15,7 +15,7 @@ class SessionsListenerSpec extends ObjectBehavior
{
public function let(Mink $mink, ScenarioTested $event, FeatureNode $feature, ScenarioNode $scenario, Suite $suite)
{
$this->beConstructedWith($mink, 'goutte', 'selenium2', ['selenium2', 'sahi']);
$this->beConstructedWith($mink, 'browserkit_http', 'selenium2', ['selenium2', 'sahi']);
$event->getSuite()->willReturn($suite);
$event->getFeature()->willReturn($feature);
@@ -38,7 +38,7 @@ class SessionsListenerSpec extends ObjectBehavior
public function it_resets_the_default_session_before_scenarios($event, $mink)
{
$mink->resetSessions()->shouldBeCalled();
$mink->setDefaultSessionName('goutte')->shouldBeCalled();
$mink->setDefaultSessionName('browserkit_http')->shouldBeCalled();
$this->prepareDefaultMinkSession($event);
}
@@ -120,7 +120,7 @@ class SessionsListenerSpec extends ObjectBehavior
public function it_fails_when_the_javascript_session_is_used_but_not_defined($event, $mink, $feature, $suite)
{
$suite->hasSetting('mink_javascript_session')->willReturn(false);
$this->beConstructedWith($mink, 'goutte', null);
$this->beConstructedWith($mink, 'browserkit_http', null);
$feature->getTags()->willReturn(['javascript']);
$this->shouldThrow(new ProcessingException('The @javascript tag cannot be used without enabling a javascript session'))
@@ -151,7 +151,7 @@ class SessionsListenerSpec extends ObjectBehavior
{
$scenario->hasTag('insulated')->willReturn(true);
$mink->stopSessions()->shouldBeCalled();
$mink->setDefaultSessionName('goutte')->shouldBeCalled();
$mink->setDefaultSessionName('browserkit_http')->shouldBeCalled();
$this->prepareDefaultMinkSession($event);
}
@@ -160,7 +160,7 @@ class SessionsListenerSpec extends ObjectBehavior
{
$feature->hasTag('insulated')->willReturn(true);
$mink->stopSessions()->shouldBeCalled();
$mink->setDefaultSessionName('goutte')->shouldBeCalled();
$mink->setDefaultSessionName('browserkit_http')->shouldBeCalled();
$this->prepareDefaultMinkSession($event);
}