From 80b326eb8258fc2b3190fda90b4e373218acfd05 Mon Sep 17 00:00:00 2001 From: Kamil Kokot Date: Fri, 12 Jun 2026 17:17:29 +0200 Subject: [PATCH] Fix MinkContext::getTranslationResources() return type; update checkout action MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Behat 4 added ': array' to TranslatableContext::getTranslationResources(), causing a fatal "must be compatible" error. Add the return type to both getTranslationResources() and getMinkTranslationResources(); also guard glob() with ?: [] since it can return false when no files match. Update actions/checkout to v5 (Node 24 compatible) — v4 breaks on GitHub Actions after June 16 2026. Co-Authored-By: Claude Sonnet 4.6 (1M context) --- .github/workflows/test.yaml | 2 +- src/Behat/MinkExtension/Context/MinkContext.php | 12 +++--------- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 93f2196..fd2664f 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -41,7 +41,7 @@ jobs: symfony-version: '8.1.*' steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v5 - name: Setup PHP uses: shivammathur/setup-php@v2 diff --git a/src/Behat/MinkExtension/Context/MinkContext.php b/src/Behat/MinkExtension/Context/MinkContext.php index d4e0cbe..aa7c36d 100644 --- a/src/Behat/MinkExtension/Context/MinkContext.php +++ b/src/Behat/MinkExtension/Context/MinkContext.php @@ -298,20 +298,14 @@ class MinkContext extends RawMinkContext implements TranslatableContext system(sprintf($this->getMinkParameter('show_cmd'), escapeshellarg($filename))); } - /** - * @return array - */ - public static function getTranslationResources() + public static function getTranslationResources(): array { return self::getMinkTranslationResources(); } - /** - * @return array - */ - public static function getMinkTranslationResources() + public static function getMinkTranslationResources(): array { - return glob(__DIR__.'/../../../../i18n/*.xliff'); + return glob(__DIR__.'/../../../../i18n/*.xliff') ?: []; } protected function fixStepArgument($argument)