From 82fb06bb57f2ce3428f6696d58a53de699ea685d Mon Sep 17 00:00:00 2001 From: Christophe Coevoet Date: Sat, 26 Apr 2014 23:34:44 +0200 Subject: [PATCH] Renamed the SauceLabsFactory for consistent casing --- doc/index.rst | 17 +++++++++++++++-- ...FactorySpec.php => SauceLabsFactorySpec.php} | 6 +++--- src/Behat/MinkExtension/Extension.php | 4 ++-- ...aucelabsFactory.php => SauceLabsFactory.php} | 4 ++-- 4 files changed, 22 insertions(+), 9 deletions(-) rename spec/Behat/MinkExtension/ServiceContainer/Driver/{SaucelabsFactorySpec.php => SauceLabsFactorySpec.php} (70%) rename src/Behat/MinkExtension/ServiceContainer/Driver/{SaucelabsFactory.php => SauceLabsFactory.php} (97%) diff --git a/doc/index.rst b/doc/index.rst index dfa5ce0..e3900f7 100644 --- a/doc/index.rst +++ b/doc/index.rst @@ -230,7 +230,7 @@ the following parameters to avoid the validation error triggered by Guzzle : my_session: selenium2: ~ -* ``SaucelabsDriver`` - special flavor of the Selenium2Driver configured to use the +* ``SauceLabsDriver`` - special flavor of the Selenium2Driver configured to use the selenium2 hosted installation of saucelabs.com. In order to use it, modify your ``behat.yml`` profile: @@ -241,7 +241,20 @@ the following parameters to avoid the validation error triggered by Guzzle : Behat\MinkExtension\Extension: sessions: my_session: - saucelabs: ~ + sauce_labs: ~ + +* ``BrowserStackDriver`` - special flavor of the Selenium2Driver configured to use the + selenium2 hosted installation of browserstack.com. In order to use it, modify your + ``behat.yml`` profile: + + .. code-block:: yaml + + default: + extensions: + Behat\MinkExtension\Extension: + sessions: + my_session: + browser_stack: ~ * ``SeleniumDriver`` - javascript driver. In order to use it, modify your ``behat.yml`` profile: diff --git a/spec/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactorySpec.php b/spec/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactorySpec.php similarity index 70% rename from spec/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactorySpec.php rename to spec/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactorySpec.php index eedfcd3..21bb10c 100644 --- a/spec/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactorySpec.php +++ b/spec/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactorySpec.php @@ -4,16 +4,16 @@ namespace spec\Behat\MinkExtension\ServiceContainer\Driver; use PhpSpec\ObjectBehavior; -class SaucelabsFactorySpec extends ObjectBehavior +class SauceLabsFactorySpec extends ObjectBehavior { function it_is_a_driver_factory() { $this->shouldHaveType('Behat\MinkExtension\ServiceContainer\Driver\DriverFactory'); } - function it_is_named_saucelabs() + function it_is_named_sauce_labs() { - $this->getDriverName()->shouldReturn('saucelabs'); + $this->getDriverName()->shouldReturn('sauce_labs'); } function it_supports_javascript() diff --git a/src/Behat/MinkExtension/Extension.php b/src/Behat/MinkExtension/Extension.php index 80d5da9..fcb52ab 100644 --- a/src/Behat/MinkExtension/Extension.php +++ b/src/Behat/MinkExtension/Extension.php @@ -15,7 +15,7 @@ use Behat\MinkExtension\ServiceContainer\Driver\BrowserStackFactory; use Behat\MinkExtension\ServiceContainer\Driver\DriverFactory; use Behat\MinkExtension\ServiceContainer\Driver\GoutteFactory; use Behat\MinkExtension\ServiceContainer\Driver\SahiFactory; -use Behat\MinkExtension\ServiceContainer\Driver\SaucelabsFactory; +use Behat\MinkExtension\ServiceContainer\Driver\SauceLabsFactory; use Behat\MinkExtension\ServiceContainer\Driver\Selenium2Factory; use Behat\MinkExtension\ServiceContainer\Driver\SeleniumFactory; use Behat\MinkExtension\ServiceContainer\Driver\ZombieFactory; @@ -52,7 +52,7 @@ class Extension implements ExtensionInterface $this->registerDriverFactory(new SahiFactory()); $this->registerDriverFactory(new SeleniumFactory()); $this->registerDriverFactory(new Selenium2Factory()); - $this->registerDriverFactory(new SaucelabsFactory()); + $this->registerDriverFactory(new SauceLabsFactory()); $this->registerDriverFactory(new BrowserStackFactory()); $this->registerDriverFactory(new ZombieFactory()); } diff --git a/src/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactory.php b/src/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactory.php similarity index 97% rename from src/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactory.php rename to src/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactory.php index 21572af..b3a4337 100644 --- a/src/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactory.php +++ b/src/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactory.php @@ -12,14 +12,14 @@ namespace Behat\MinkExtension\ServiceContainer\Driver; use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition; -class SaucelabsFactory extends Selenium2Factory +class SauceLabsFactory extends Selenium2Factory { /** * {@inheritdoc} */ public function getDriverName() { - return 'saucelabs'; + return 'sauce_labs'; } /**