Refactoring as per stof 's sugestions

This commit is contained in:
Shashikant
2015-03-02 19:34:10 +00:00
parent 4f3c1a6ae5
commit 976f9c32da

View File

@@ -1,12 +1,5 @@
<?php <?php
/*
* This file is part of the Behat MinkExtension.
* (c) Shashikant jagtap <shashikant.jagtap@aol.co.uk>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Behat\MinkExtension\ServiceContainer\Driver; namespace Behat\MinkExtension\ServiceContainer\Driver;
@@ -53,73 +46,73 @@ class AppiumFactory extends Selenium2Factory
$node $node
->children() ->children()
->scalarNode('automationName')->defaultValue('Appium')->end() ->scalarNode('automationName')->defaultValue('Appium')->end()
->scalarNode('platformName')->end() ->scalarNode('platformName')->end()
->scalarNode('platformVersion')->end() ->scalarNode('platformVersion')->end()
->scalarNode('deviceName')->end() ->scalarNode('deviceName')->end()
->scalarNode('app')->end() ->scalarNode('app')->end()
->scalarNode('browserName')->end() ->scalarNode('browserName')->end()
->scalarNode('newCommandTimeout')->end() ->scalarNode('newCommandTimeout')->end()
->booleanNode('autoLaunch')->end() ->booleanNode('autoLaunch')->end()
->scalarNode('language')->end() ->scalarNode('language')->end()
->scalarNode('locale')->end() ->scalarNode('locale')->end()
->scalarNode('udid')->end() ->scalarNode('udid')->end()
->scalarNode('orientation')->end() ->scalarNode('orientation')->end()
->booleanNode('autoWebview')->end() ->booleanNode('autoWebview')->end()
->booleanNode('noReset')->end() ->booleanNode('noReset')->end()
->booleanNode('fullReset')->end() ->booleanNode('fullReset')->end()
//ANDROID ONLY //ANDROID ONLY
->scalarNode('appActivity')->end() ->scalarNode('appActivity')->end()
->scalarNode('appPackage')->end() ->scalarNode('appPackage')->end()
->scalarNode('appWaitActivity')->end() ->scalarNode('appWaitActivity')->end()
->scalarNode('appWaitPackage')->end() ->scalarNode('appWaitPackage')->end()
->scalarNode('deviceReadyTimeout')->end() ->scalarNode('deviceReadyTimeout')->end()
->scalarNode('androidCoverage')->end() ->scalarNode('androidCoverage')->end()
->scalarNode('androidDeviceReadyTimeout')->end() ->scalarNode('androidDeviceReadyTimeout')->end()
->scalarNode('androidDeviceSocket')->end() ->scalarNode('androidDeviceSocket')->end()
->scalarNode('avd')->end() ->scalarNode('avd')->end()
->scalarNode('avdLaunchTimeout')->end() ->scalarNode('avdLaunchTimeout')->end()
->scalarNode('avdReadyTimeout')->end() ->scalarNode('avdReadyTimeout')->end()
->scalarNode('avdArgs')->end() ->scalarNode('avdArgs')->end()
->scalarNode('keystorePassword')->end() ->scalarNode('keystorePassword')->end()
->scalarNode('keystorePath')->end() ->scalarNode('keystorePath')->end()
->scalarNode('keyAlias')->end() ->scalarNode('keyAlias')->end()
->scalarNode('keyPassword')->end() ->scalarNode('keyPassword')->end()
->scalarNode('chromedriverExecutable')->end() ->scalarNode('chromedriverExecutable')->end()
->scalarNode('autoWebviewTimeout')->end() ->scalarNode('autoWebviewTimeout')->end()
->scalarNode('intentAction')->end() ->scalarNode('intentAction')->end()
->scalarNode('intentCategory')->end() ->scalarNode('intentCategory')->end()
->scalarNode('intentFlags')->end() ->scalarNode('intentFlags')->end()
->scalarNode('optionalIntentArguments')->end() ->scalarNode('optionalIntentArguments')->end()
->booleanNode('enablePerformanceLogging')->end() ->booleanNode('enablePerformanceLogging')->end()
->booleanNode('useKeystore')->end() ->booleanNode('useKeystore')->end()
->booleanNode('stopAppOnReset')->end() ->booleanNode('stopAppOnReset')->end()
->booleanNode('unicodeKeyboard')->end() ->booleanNode('unicodeKeyboard')->end()
->booleanNode('resetKeyboard')->end() ->booleanNode('resetKeyboard')->end()
->booleanNode('noSign')->end() ->booleanNode('noSign')->end()
->booleanNode('ignoreUnimportantViews')->end() ->booleanNode('ignoreUnimportantViews')->end()
// IOS ONLY // IOS ONLY
->scalarNode('calendarFormat')->end() ->scalarNode('calendarFormat')->end()
->scalarNode('bundleId')->end() ->scalarNode('bundleId')->end()
->scalarNode('udid')->end() ->scalarNode('udid')->end()
->scalarNode('launchTimeout')->end() ->scalarNode('launchTimeout')->end()
->scalarNode('localizableStringsDir')->end() ->scalarNode('localizableStringsDir')->end()
->scalarNode('processArguments')->end() ->scalarNode('processArguments')->end()
->scalarNode('interKeyDelay')->end() ->scalarNode('interKeyDelay')->end()
->scalarNode('sendKeyStrategy')->end() ->scalarNode('sendKeyStrategy')->end()
->scalarNode('screenshotWaitTimeout')->end() ->scalarNode('screenshotWaitTimeout')->end()
->scalarNode('waitForAppScript')->end() ->scalarNode('waitForAppScript')->end()
->booleanNode('locationServicesEnabled')->end() ->booleanNode('locationServicesEnabled')->end()
->booleanNode('locationServicesAuthorized')->end() ->booleanNode('locationServicesAuthorized')->end()
->booleanNode('autoAcceptAlerts')->end() ->booleanNode('autoAcceptAlerts')->end()
->booleanNode('autoDismissAlerts')->end() ->booleanNode('autoDismissAlerts')->end()
->booleanNode('nativeInstrumentsLib')->end() ->booleanNode('nativeInstrumentsLib')->end()
->booleanNode('nativeWebTap')->end() ->booleanNode('nativeWebTap')->end()
->booleanNode('safariAllowPopups')->end() ->booleanNode('safariAllowPopups')->end()
->booleanNode('safariIgnoreFraudWarning')->end() ->booleanNode('safariIgnoreFraudWarning')->end()
->booleanNode('safariOpenLinksInBackground')->end() ->booleanNode('safariOpenLinksInBackground')->end()
->booleanNode('keepKeyChains')->end() ->booleanNode('keepKeyChains')->end()
->booleanNode('showIOSLog')->end() ->booleanNode('showIOSLog')->end()
->end() ->end()
; ;