From 6477bb6a2fd1bb44ea7af3b53598214fc04fea12 Mon Sep 17 00:00:00 2001 From: Bastien GARCIA Date: Fri, 21 Jul 2023 14:27:05 +0200 Subject: [PATCH 1/2] Added support for client configuration when using BrowserKit --- .../ServiceContainer/Driver/BrowserKitFactory.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserKitFactory.php b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserKitFactory.php index 9b0e8d3..3d3ea6e 100644 --- a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserKitFactory.php +++ b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserKitFactory.php @@ -56,8 +56,15 @@ class BrowserKitFactory implements DriverFactory throw new \RuntimeException(sprintf('Class %s not found, did you install symfony/browser-kit 4.4+?', HttpBrowser::class)); } + $parameters[] = $config['http_client_parameters'] ?? []; + + $httpClientDefinition = new Definition(null, $parameters); + $httpClientDefinition->setFactory(HttpClient::class.'::create'); + return new Definition(BrowserKitDriver::class, [ - new Definition(HttpBrowser::class), + new Definition(HttpBrowser::class, [ + $httpClientDefinition, + ]), '%mink.base_url%', ]); } From b30b2ba332aae65736a33490ae81cdee4f0fba36 Mon Sep 17 00:00:00 2001 From: Bastien GARCIA Date: Fri, 18 Aug 2023 09:35:12 +0200 Subject: [PATCH 2/2] Corrected Behat test after a change to Wikipedia's website --- features/search.feature | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/features/search.feature b/features/search.feature index b4e08ef..b9698d4 100644 --- a/features/search.feature +++ b/features/search.feature @@ -6,11 +6,11 @@ Feature: Search Scenario: Searching for a page that does exist Given I am on "/wiki/Main_Page" When I fill in "search" with "Behavior Driven Development" - And I press "searchButton" + And I press "Search" Then I should see "agile software development" Scenario: Searching for a page that does NOT exist Given I am on "/wiki/Main_Page" When I fill in "search" with "Glory Driven Development" - And I press "searchButton" + And I press "Search" Then I should see "Search results"