veyra/friends-of-behat-symfony-extension
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

bug #75 Hotfix for weird bug in Sylius (pamil)

Browse Source 
This PR was merged into the 2.0 branch.

Discussion
----------

Couldn't reproduce it, removing that lazy setting fixes the issue though.

There's a quite random error:

```
LogicException: The page history is empty. in vendor/symfony/browser-kit/History.php:95
```

It happens when sending a form or clicking a link, but not always. Ex. when running the whole directory of features, one scenario in a subdirectory fails. When running that scenario only, it passes. When running that scenario in between of other scenarios in that directory, it still passes.

https://travis-ci.org/Sylius/Sylius/jobs/507555578#L1787

Commits
-------

69d150b3dc Hotfix for weird bug in Sylius
This commit is contained in:
Kamil Kokot
2019-03-17 23:35:03 +01:00
committed by GitHub
parent c22e21b724 69d150b3dc
commit 22692fb4a2
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php
View File

@@ -54,7 +54,6 @@ final class FriendsOfBehatSymfonyExtensionExtension extends Extension implements
{ {
$minkDefinition = new Definition(Mink::class, ['mink']); $minkDefinition = new Definition(Mink::class, ['mink']);
$minkDefinition->setPublic(true); $minkDefinition->setPublic(true);
$minkDefinition->setLazy(true);
$minkDefinition->setFactory([new Reference('behat.service_container'), 'get']); $minkDefinition->setFactory([new Reference('behat.service_container'), 'get']);
$container->setDefinition('behat.mink', $minkDefinition); $container->setDefinition('behat.mink', $minkDefinition);