From 463c274dbc3a44551993c044d4e53ab6ae948bea Mon Sep 17 00:00:00 2001
From: Kamil Kokot <kamil@kokot.me>
Date: Mon, 31 Dec 2018 16:53:20 +0100
Subject: [PATCH] Create minimal passing scenario

---
 features/not_crashing_behat.feature           | 164 ------------------
 features/running_bare_behat_scenarios.feature |  51 ++++++
 src/ServiceContainer/SymfonyExtension.php     |  11 +-
 3 files changed, 59 insertions(+), 167 deletions(-)
 delete mode 100644 features/not_crashing_behat.feature
 create mode 100644 features/running_bare_behat_scenarios.feature

diff --git a/features/not_crashing_behat.feature b/features/not_crashing_behat.feature
deleted file mode 100644
index e1728ff..0000000
--- a/features/not_crashing_behat.feature
+++ /dev/null
@@ -1,164 +0,0 @@
-Feature: Not crashing Behat
-    In order to use this extension
-    As a Behat User
-    I want to have Behat up and running after enabling this extension
-
-    Scenario: Successful boot the Symfony kernel with autoconfiguration
-        Given a Behat configuration containing:
-        """
-        default:
-            extensions:
-                FriendsOfBehat\SymfonyExtension: ~
-        """
-        And a file "app/autoload.php" containing:
-        """
-        <?php
-
-        """
-        And a file "app/AppKernel.php" containing:
-        """
-        <?php
-
-        use Symfony\Component\HttpKernel\Kernel;
-        use Symfony\Component\Config\Loader\LoaderInterface;
-
-        class AppKernel extends Kernel
-        {
-            public function registerBundles() { return []; }
-            public function registerContainerConfiguration(LoaderInterface $loader) {}
-        }
-        """
-        And a feature file with passing scenario
-        When I run Behat
-        Then it should pass
-
-    Scenario: Successful boot the Symfony kernel with explicit configuration
-        Given a Behat configuration containing:
-        """
-        default:
-            extensions:
-                FriendsOfBehat\SymfonyExtension:
-                    kernel:
-                        path: app/MyKernel.php
-                        class: MyKernel
-                        env: test
-                        debug: true
-        """
-        And a file "app/autoload.php" containing:
-        """
-        <?php
-
-        """
-        And a file "app/MyKernel.php" containing:
-        """
-        <?php
-
-        use Symfony\Component\HttpKernel\Kernel;
-        use Symfony\Component\Config\Loader\LoaderInterface;
-
-        class MyKernel extends Kernel
-        {
-            public function registerBundles() { return []; }
-            public function registerContainerConfiguration(LoaderInterface $loader) {}
-        }
-        """
-        And a feature file with passing scenario
-        When I run Behat
-        Then it should pass
-
-
-    Scenario: Successful boot the Symfony 4 kernel with autoconfiguration
-        Given a Behat configuration containing:
-        """
-        default:
-            extensions:
-                FriendsOfBehat\SymfonyExtension: ~
-        """
-        And a file ".env" containing:
-        """
-        APP_ENV=dev
-        """
-        And a file "src/Kernel.php" containing:
-        """
-        <?php
-
-        namespace App;
-
-        use Symfony\Component\HttpKernel\Kernel as BaseKernel;
-        use Symfony\Component\Config\Loader\LoaderInterface;
-
-        class Kernel extends BaseKernel
-        {
-            public function registerBundles() { return []; }
-            public function registerContainerConfiguration(LoaderInterface $loader) {}
-        }
-        """
-        And a feature file with passing scenario
-        When I run Behat
-        Then it should pass
-
-    Scenario: Successful boot the Symfony 4 kernel with explicit configuration
-        Given a Behat configuration containing:
-        """
-        default:
-            extensions:
-                FriendsOfBehat\SymfonyExtension:
-                    env_file: ../config/.env_in_memory
-                    kernel:
-                        path: src/MyKernel.php
-                        class: MyKernel
-        """
-        And a file "../config/.env_in_memory" containing:
-        """
-        APP_ENV=dev
-        """
-        And a file "src/MyKernel.php" containing:
-        """
-        <?php
-
-        use Symfony\Component\HttpKernel\Kernel;
-        use Symfony\Component\Config\Loader\LoaderInterface;
-
-        class MyKernel extends Kernel
-        {
-            public function registerBundles() { return []; }
-            public function registerContainerConfiguration(LoaderInterface $loader) {}
-        }
-        """
-        And a feature file with passing scenario
-        When I run Behat
-        Then it should pass
-
-    Scenario: This extension used dist file by default
-        Given a Behat configuration containing:
-        """
-        default:
-            extensions:
-                FriendsOfBehat\SymfonyExtension:
-                    env_file: .env_in_memory
-                    kernel:
-                        path: src/MyKernel.php
-                        class: MyKernel
-                        env: dev
-                        debug: true
-        """
-        And a file ".env_in_memory.dist" containing:
-        """
-        APP_ENV=dev
-        """
-        And a file "src/MyKernel.php" containing:
-        """
-        <?php
-
-        use Symfony\Component\HttpKernel\Kernel;
-        use Symfony\Component\Config\Loader\LoaderInterface;
-
-        class MyKernel extends Kernel
-        {
-            public function registerBundles() { return []; }
-            public function registerContainerConfiguration(LoaderInterface $loader) {}
-        }
-        """
-        And a feature file with passing scenario
-        When I run Behat
-        Then it should pass
diff --git a/features/running_bare_behat_scenarios.feature b/features/running_bare_behat_scenarios.feature
new file mode 100644
index 0000000..afddca2
--- /dev/null
+++ b/features/running_bare_behat_scenarios.feature
@@ -0,0 +1,51 @@
+Feature: Running bare Behat scenarios
+
+    Scenario: Running Behat with SymfonyExtension
+        Given a Behat configuration containing:
+        """
+        default:
+            extensions:
+                FriendsOfBehat\SymfonyExtension:
+                    kernel:
+                        path: app/AppKernel.php
+                        class: AppKernel
+
+                Behat\MinkExtension:
+                    base_url: "http://localhost:8080/"
+                    default_session: symfony
+                    sessions:
+                        symfony:
+                            symfony: ~
+        """
+        And a file "app/AppKernel.php" containing:
+        """
+        <?php
+
+        use Symfony\Component\HttpKernel\Kernel;
+        use Symfony\Component\DependencyInjection\ContainerBuilder;
+        use Symfony\Component\Config\Loader\LoaderInterface;
+
+        class AppKernel extends Kernel
+        {
+            public function registerBundles()
+            {
+                return [
+                    new \Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
+                    new \FriendsOfBehat\SymfonyExtension\Bundle\FriendsOfBehatSymfonyExtensionBundle(),
+                ];
+            }
+
+            public function registerContainerConfiguration(LoaderInterface $loader)
+            {
+                $loader->load(function (ContainerBuilder $container): void {
+                    $container->loadFromExtension('framework', [
+                        'test' => $this->getEnvironment() === 'test',
+                        'secret' => 'Pigeon',
+                    ]);
+                });
+            }
+        }
+        """
+        And a feature file with passing scenario
+        When I run Behat
+        Then it should pass
diff --git a/src/ServiceContainer/SymfonyExtension.php b/src/ServiceContainer/SymfonyExtension.php
index fac137b..215054c 100644
--- a/src/ServiceContainer/SymfonyExtension.php
+++ b/src/ServiceContainer/SymfonyExtension.php
@@ -50,12 +50,13 @@ final class SymfonyExtension implements Extension
     {
         $builder
             ->children()
-                ->scalarNode('env_file')->end()
+                ->scalarNode('env_file')->defaultNull()->end()
                 ->arrayNode('kernel')
                     ->addDefaultsIfNotSet()
                     ->children()
-                        ->scalarNode('class')->defaultValue('App\\Kernel')->end()
-                        ->scalarNode('env')->defaultValue('test')->end()
+                        ->scalarNode('path')->defaultNull()->end()
+                        ->scalarNode('class')->isRequired()->end()
+                        ->scalarNode('env')->defaultValue('test')->cannotBeEmpty()->end()
                         ->booleanNode('debug')->defaultTrue()->end()
                     ->end()
                 ->end()
@@ -115,6 +116,10 @@ final class SymfonyExtension implements Extension
         $definition->addMethodCall('boot');
         $definition->setPublic(true);
 
+        if (null !== $config['path']) {
+            $definition->setFile($config['path']);
+        }
+
         $container->setDefinition(self::KERNEL_ID, $definition);
     }