From 394c417675bcce136ef7be76848ee65ba9245fd6 Mon Sep 17 00:00:00 2001 From: cv65kr Date: Thu, 18 Jun 2020 20:24:36 +0200 Subject: [PATCH 1/2] Missing class for Symfony 5 --- .../FriendsOfBehatSymfonyExtensionExtension.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php b/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php index 88cfeac..96fb089 100644 --- a/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php +++ b/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php @@ -10,7 +10,6 @@ use Behat\Mink\Session; use FriendsOfBehat\SymfonyExtension\Mink\MinkParameters; use FriendsOfBehat\SymfonyExtension\ServiceContainer\SymfonyExtension; use Symfony\Bundle\FrameworkBundle\KernelBrowser; -use Symfony\Component\BrowserKit\Client; use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\DependencyInjection\ContainerInterface; @@ -79,9 +78,12 @@ final class FriendsOfBehatSymfonyExtensionExtension extends Extension implements return; } - foreach ([Client::class, KernelBrowser::class, HttpKernelBrowser::class] as $class) { - $container->setAlias($class, 'test.client'); + if (\class_exists('Symfony\Component\BrowserKit\Client')) { + $container->setAlias('Symfony\Component\BrowserKit\Client', 'test.client'); } + + $container->setAlias(KernelBrowser::class, 'test.client'); + $container->setAlias(HttpKernelBrowser::class, 'test.client'); } private function provideMinkIntegration(ContainerBuilder $container): void From d597aa3c6c92e060fd61f9c3b99506b816acf22a Mon Sep 17 00:00:00 2001 From: Kamil Kokot Date: Thu, 5 Nov 2020 21:45:28 +0100 Subject: [PATCH 2/2] Use imported classname for Client --- .../FriendsOfBehatSymfonyExtensionExtension.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php b/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php index 96fb089..45a61f1 100644 --- a/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php +++ b/src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension.php @@ -10,6 +10,7 @@ use Behat\Mink\Session; use FriendsOfBehat\SymfonyExtension\Mink\MinkParameters; use FriendsOfBehat\SymfonyExtension\ServiceContainer\SymfonyExtension; use Symfony\Bundle\FrameworkBundle\KernelBrowser; +use Symfony\Component\BrowserKit\Client; use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; use Symfony\Component\DependencyInjection\ContainerBuilder; use Symfony\Component\DependencyInjection\ContainerInterface; @@ -78,8 +79,8 @@ final class FriendsOfBehatSymfonyExtensionExtension extends Extension implements return; } - if (\class_exists('Symfony\Component\BrowserKit\Client')) { - $container->setAlias('Symfony\Component\BrowserKit\Client', 'test.client'); + if (class_exists(Client::class)) { + $container->setAlias(Client::class, 'test.client'); } $container->setAlias(KernelBrowser::class, 'test.client');