veyra/friends-of-behat-symfony-extension
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Make exception messages great again

Browse Source
This commit is contained in:
Kamil Kokot
2018-12-31 16:03:00 +01:00
parent 9cc5df85bf
commit 9b3672d7f2
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Context/Environment/Handler/ContextServiceEnvironmentHandler.php
View File

@@ -159,13 +159,13 @@ final class ContextServiceEnvironmentHandler implements EnvironmentHandler
try {
$this->symfonyKernel->getBundle('FriendsOfBehatSymfonyExtensionBundle');
} catch (\InvalidArgumentException $exception) {
throw new \DomainException(sprintf(
'Kernel "%s" used in Behat in "%s" environment with debug %s needs to have "%s" bundle registered.',
throw new \RuntimeException(sprintf(
'Kernel "%s" used by Behat with "%s" environment and debug %s needs to have "%s" bundle registered.',
get_class($this->symfonyKernel),
$this->symfonyKernel->getEnvironment(),
$this->symfonyKernel->isDebug() ? 'enabled' : 'disabled',
FriendsOfBehatSymfonyExtensionBundle::class
), 0, $exception);
));
}
return $this->symfonyKernel->getContainer();

14
src/Driver/SymfonyDriver.php
View File

@@ -12,16 +12,16 @@ final class SymfonyDriver extends BrowserKitDriver
{
public function __construct(KernelInterface $kernel, string $baseUrl)
{
$testClient = $kernel->getContainer()->get('test.client');
if (!$testClient instanceof Client) {
if (!$kernel->getContainer()->has('test.client')) {
throw new \RuntimeException(sprintf(
'Expected service "test.client" to be an instance of "%s", got "%s" instead.',
Client::class,
\is_object($testClient) ? \get_class($testClient) : \gettype($testClient)
'Kernel "%s" used by Behat with "%s" environment and debug %s does not have "test.client" service. ' . "\n" .
'Please make sure the kernel is using "test" environment or have "framework.test" configuration option enabled.',
get_class($kernel),
$kernel->getEnvironment(),
$kernel->isDebug() ? 'enabled' : 'disabled'
));
}
parent::__construct($testClient, $baseUrl);
parent::__construct($kernel->getContainer()->get('test.client'), $baseUrl);
}
}