Commit Graph

96 Commits

Author SHA1 Message Date
Kamil Kokot
9cede4d612 Test injecting services 2019-01-09 22:40:32 +01:00
Kamil Kokot
d4efe9a6df Simplify services definition in Behat 2019-01-09 22:37:18 +01:00
Kamil Kokot
11f5a326b3 Test injecting parameters 2019-01-09 22:35:57 +01:00
Kamil Kokot
7250dfca76 Get bare Behat scenario running 2019-01-09 22:29:50 +01:00
Bartosz Pietrzak
742d3358b5 Injected parameter test POC 2019-01-09 19:23:39 +01:00
Kamil Kokot
9c41bdbcba Compress scenario 2018-12-31 17:25:05 +01:00
Kamil Kokot
032ecb64d2 Replace FOB/TestContext with local TestContext 2018-12-31 16:57:35 +01:00
Kamil Kokot
463c274dbc Create minimal passing scenario 2018-12-31 16:54:12 +01:00
Kamil Kokot
3ef67d3efc Simplify configuration 2018-12-31 16:06:05 +01:00
Kamil Kokot
9b3672d7f2 Make exception messages great again 2018-12-31 16:03:00 +01:00
Kamil Kokot
9cc5df85bf Throw an exception if the bundle isn't registered 2018-12-31 15:48:56 +01:00
Kamil Kokot
5151d30b24 Minor fixes 2018-12-31 15:47:48 +01:00
Kamil Kokot
f334860d5c Make SymfonyExtension great again 2018-12-28 19:55:49 +01:00
Kamil Kokot
0ecd038e61 Make MinkParameters imitate PHP arrays 2018-12-28 15:40:13 +01:00
Kamil Kokot
9b6206d47b Add MinkParameters support 2018-12-28 15:24:33 +01:00
Kamil Kokot
50fc509fb3 SymfonyExtension v2.0: proof of concept 2018-12-28 13:08:51 +01:00
Kamil Kokot
3ef0d0dcf3 feature #41 Support: remove Symfony 4.0 and add Symfony 4.2 (pamil)
This PR was merged into the 1.4-dev branch.

Discussion
----------



Commits
-------

a1792f934f Support: remove Symfony 4.0 and add Symfony 4.2
2018-12-19 15:42:27 +01:00
Kamil Kokot
a1792f934f Support: remove Symfony 4.0 and add Symfony 4.2 2018-12-19 15:37:07 +01:00
Kamil Kokot
7f58add0f4 feature #29 Proposal: Add autoconfiguration for Symfony 4, other tweaks (adiq)
This PR was merged into the 1.4-dev branch.

Discussion
----------

So this is my proposal for SymfonyExtension. Related to #28 

What it changes:

1. Adds autoconfiguration for Symfony 4 (when default `src/Kernel.php` is detected); Improves DX.

So when project bein compliant with new Symfony 4 structure, the configuration will look like:
```
            extensions:
                FriendsOfBehat\SymfonyExtension: ~
```
The standard `.env` file is loaded by default.

2. Explicit settings of `env` and `debug` parameters will override the configuration loaded from `.env` file. This also improves DX, as there is no need for hacky workarounds to get behat working.

3. Fixed issue with the badly named configuration `$config['kernel']['kernel'] = $debugMode;` in 1a39d31f5e

4. Tweaked README to include new configuration details


When it might seem only like an improvement, it's required to get behat working on new Symfony 4 structure when you: do not want to store a separate copy of `.env` with only `APP_ENV` changed to `test`, do not want to change those settings back and forth in `.env` file; which I consider not good practice and not good DX for sure 😄 

Commits
-------

09c6530115 Add autoconfiguration for Symfony 4, allow overriding .env setting by using explicit env and debug settings, tweaks
141074a24e Tweak README to include new configuration details for Symfony 4, tweak variable name
149d41087f Add symfony 4 configuration loading when bootstrap is null; tweaked formatting, naming, tests and readme
49c4fc2a0e Tweak README typos
99db863175 Tweaks after CR: remove obsolete docblocks, fix code formatting to match ECS
2018-12-19 15:08:16 +01:00
Adrian Zmenda
99db863175 Tweaks after CR: remove obsolete docblocks, fix code formatting to match ECS 2018-12-09 16:11:00 +01:00
Adrian Zmenda
49c4fc2a0e Tweak README typos 2018-12-09 15:51:39 +01:00
Adrian Zmenda
149d41087f Add symfony 4 configuration loading when bootstrap is null; tweaked formatting, naming, tests and readme 2018-12-09 15:51:11 +01:00
Adrian Zmenda
141074a24e Tweak README to include new configuration details for Symfony 4, tweak variable name 2018-12-09 15:47:50 +01:00
Adrian Zmenda
09c6530115 Add autoconfiguration for Symfony 4, allow overriding .env setting by using explicit env and debug settings, tweaks 2018-12-09 15:43:50 +01:00
Łukasz Chruściel
4dd58a5831 Merge pull request #40 from solivier/issue_39
Fix issue 39
2018-11-02 14:44:36 +01:00
Olivier Soulet
10de8e65d3 Fix #39 2018-10-29 20:51:15 +01:00
Kamil Kokot
12d4c58ec2 Merge pull request #38 from Zales0123/load-dist-files-by-default
Use dist env file by default
2018-09-25 13:18:21 +02:00
Mateusz Zalewski
de853c0fe3 Use dist env file by default 2018-09-20 11:52:20 +02:00
Kamil Kokot
291530353b Merge pull request #37 from pamil/phpstan
Install PHPStan and require it passing on the max level
2018-08-01 16:35:39 +02:00
Kamil Kokot
794b298338 Run PHPStan on Travis CI 2018-08-01 16:30:28 +02:00
Kamil Kokot
fa42a8e00f Fix errors reported by PHPStan 2018-08-01 16:11:34 +02:00
Kamil Kokot
872be1b1a4 Install PHPStan 2018-08-01 15:58:37 +02:00
Kamil Kokot
79ce0976ab Merge pull request #35 from pamil/coding-standard
Add SyliusLabs/CodingStandard and apply coding standard fixes
2018-08-01 15:56:03 +02:00
Kamil Kokot
568d00ad58 Merge pull request #36 from pamil/minor-fixes
Update LICENSE, README and remove license comments from PHP files
2018-08-01 15:40:05 +02:00
Kamil Kokot
725abfd603 Apply coding standard fixes 2018-08-01 15:38:05 +02:00
Kamil Kokot
7313db0071 Add SyliusLabs/CodingStandard 2018-08-01 15:38:04 +02:00
Kamil Kokot
fdd6d93fec Merge pull request #34 from pamil/symfony-3.4+
Require Symfony ^3.4|^4.0 and add testing for Symfony 4.1 on Travis CI
2018-08-01 15:37:21 +02:00
Kamil Kokot
6af6e49ec5 Remove license comments from PHP files 2018-08-01 15:32:53 +02:00
Kamil Kokot
4c2aab39ba Update LICENSE and README 2018-08-01 15:32:42 +02:00
Kamil Kokot
8352939976 Require Symfony ^3.4|^4.0 and add testing for Symfony 4.1 on Travis CI 2018-08-01 15:30:10 +02:00
Kamil Kokot
ee64406cc2 Merge pull request #33 from pamil/behat-3.4
Require Behat ^3.4
2018-08-01 15:29:29 +02:00
Kamil Kokot
f72289b6b3 Require Behat ^3.4 2018-08-01 15:23:37 +02:00
Kamil Kokot
cce520d31d Merge pull request #32 from Persata/master
Make definitions public, ensures kernels are not inlined and duplicated
2018-08-01 14:55:23 +02:00
persata
154dcdce82 Make definitions public, ensures kernels are not inlined and duplicated 2018-07-29 14:36:52 +01:00
Kamil Kokot
0989790fba Merge pull request #27 from arnolanglade/issue_25
WIP #25 - Fix scenario isolation
2018-05-25 14:59:32 +02:00
Arnaud Langlade
1b492f56d1 #25 fix scenario isolation 2018-03-14 09:06:23 +01:00
Kamil Kokot
ef2a93af4c Merge pull request #24 from aRn0D/symfony4_support
Provide Symfony 4 support
2018-03-13 16:34:43 +01:00
Arnaud Langlade
1a39d31f5e Fix review feedback 2018-03-13 15:34:12 +01:00
Arnaud Langlade
b1059a520c Symfony4 support 2018-03-03 22:23:11 +01:00
Kamil Kokot
db6193144e Merge pull request #23 from lchrusciel/symfony-driver
Add support for symfony driver
2018-02-14 15:18:16 +01:00