veyra/friends-of-behat-mink-extension
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Renamed the SauceLabsFactory for consistent casing

Browse Source
This commit is contained in:
Christophe Coevoet
2014-04-26 23:34:44 +02:00
parent 3b00c091e9
commit 82fb06bb57
4 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
doc/index.rst
View File

@@ -230,7 +230,7 @@ the following parameters to avoid the validation error triggered by Guzzle :
my_session:
selenium2: ~
* ``SaucelabsDriver`` - special flavor of the Selenium2Driver configured to use the
* ``SauceLabsDriver`` - special flavor of the Selenium2Driver configured to use the
selenium2 hosted installation of saucelabs.com. In order to use it, modify your
``behat.yml`` profile:
@@ -241,7 +241,20 @@ the following parameters to avoid the validation error triggered by Guzzle :
Behat\MinkExtension\Extension:
sessions:
my_session:
saucelabs: ~
sauce_labs: ~
* ``BrowserStackDriver`` - special flavor of the Selenium2Driver configured to use the
selenium2 hosted installation of browserstack.com. In order to use it, modify your
``behat.yml`` profile:
.. code-block:: yaml
default:
extensions:
Behat\MinkExtension\Extension:
sessions:
my_session:
browser_stack: ~
* ``SeleniumDriver`` - javascript driver. In order to use it, modify your ``behat.yml``
profile:

6
spec/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactorySpec.php → spec/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactorySpec.php
View File

@@ -4,16 +4,16 @@ namespace spec\Behat\MinkExtension\ServiceContainer\Driver;
use PhpSpec\ObjectBehavior;
class SaucelabsFactorySpec extends ObjectBehavior
class SauceLabsFactorySpec extends ObjectBehavior
{
function it_is_a_driver_factory()
{
$this->shouldHaveType('Behat\MinkExtension\ServiceContainer\Driver\DriverFactory');
}
function it_is_named_saucelabs()
function it_is_named_sauce_labs()
{
$this->getDriverName()->shouldReturn('saucelabs');
$this->getDriverName()->shouldReturn('sauce_labs');
}
function it_supports_javascript()

4
src/Behat/MinkExtension/Extension.php
View File

@@ -15,7 +15,7 @@ use Behat\MinkExtension\ServiceContainer\Driver\BrowserStackFactory;
use Behat\MinkExtension\ServiceContainer\Driver\DriverFactory;
use Behat\MinkExtension\ServiceContainer\Driver\GoutteFactory;
use Behat\MinkExtension\ServiceContainer\Driver\SahiFactory;
use Behat\MinkExtension\ServiceContainer\Driver\SaucelabsFactory;
use Behat\MinkExtension\ServiceContainer\Driver\SauceLabsFactory;
use Behat\MinkExtension\ServiceContainer\Driver\Selenium2Factory;
use Behat\MinkExtension\ServiceContainer\Driver\SeleniumFactory;
use Behat\MinkExtension\ServiceContainer\Driver\ZombieFactory;
@@ -52,7 +52,7 @@ class Extension implements ExtensionInterface
$this->registerDriverFactory(new SahiFactory());
$this->registerDriverFactory(new SeleniumFactory());
$this->registerDriverFactory(new Selenium2Factory());
$this->registerDriverFactory(new SaucelabsFactory());
$this->registerDriverFactory(new SauceLabsFactory());
$this->registerDriverFactory(new BrowserStackFactory());
$this->registerDriverFactory(new ZombieFactory());
}

4
src/Behat/MinkExtension/ServiceContainer/Driver/SaucelabsFactory.php → src/Behat/MinkExtension/ServiceContainer/Driver/SauceLabsFactory.php
View File

@@ -12,14 +12,14 @@ namespace Behat\MinkExtension\ServiceContainer\Driver;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
class SaucelabsFactory extends Selenium2Factory
class SauceLabsFactory extends Selenium2Factory
{
/**
* {@inheritdoc}
*/
public function getDriverName()
{
return 'saucelabs';
return 'sauce_labs';
}
/**